-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Educator version #948
Open
sabrinanel3
wants to merge
137
commits into
virtualcommons:main
Choose a base branch
from
sabrinanel3:educator-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Educator version #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently failing on staging deployment with TS errors:
|
- a Teacher can have multiple Classrooms - a Classroom can have multiple Students - Students are one-to-one with Users which lets them participate in Games - Teachers are one-to-one with Users which lets them sign into the website (may need to revisit this part of the schema) Co-authored-by: Tkawamura02 <[email protected]> Co-authored-by: Allen Lee <[email protected]> Co-authored-by: Scott Foster <[email protected]> Co-authored-by: Sabrina Nelson <[email protected]>
pending a feature flag, these routes/components will be part of an entirely different layout Co-authored-by: sbmota <[email protected]> Co-authored-by: Allen Lee <[email protected]> Co-authored-by: Sabrina Nelson <[email protected]>
Co-authored-by: Allen Lee <[email protected]> Co-authored-by: sbmota <[email protected]>
isTeacher flag gets added to the user object in client state when needed We should be able to get away with no other (or very minimal) changes to the client state by repurposing the lobby object similar to how we do so for freeplay/tournament lobbies
Co-authored-by: sgfost <[email protected]>
* moved dev login function on the client to AuthAPI TODO: * add generation of a passcode for signing back in as an existing student. either create a new strategy or modify existing to also take this auth token for signing back in * create the rest of the login flow, intermediate page for entering name, signing back in (passcode can be the response from a set-name call) Co-authored-by: saachibm <[email protected]> Co-authored-by: Sabrina Nelson <[email protected]>
…in classroom lobby components for student-confirm page
+ some minor cleanup CONTAINS MIGRATION
Co-authored-by: Sabrina Nelson <[email protected]> Co-authored-by: saachibm <[email protected]>
ref virtualcommons#943 Co-authored-by: Sabrina Nelson <[email protected]> Co-authored-by: Kelly Tran <[email protected]> Co-authored-by: Allen Lee <[email protected]>
classroom authToken, and student rejoinCode. + created test suites
…dent count Co-authored-by: Kelly Tran <[email protected]>
STEPS TO UPDATE LOCAL ENV: - make clean - ./configure dev - make .env - (optionally) update SHARED_APP_MODE in .env, new way to set educator mdoe - make deploy
* classroom selection is now done by id to retain a reference * fixed some vue errors in TeacherDashboard component * DELETE /classroom/ now responds with a 200 status on success * prevent login form submissions from trying to redirect to a new page
adds a tournament + round for educator mode, some form of active tournament is still needed for starting games and not breaking everything * prevent default on student confirmation page
…dashboard added inspect data route to dashboard
Co-authored-by: sgfost <[email protected]>
Co-authored-by: sgfost <[email protected]>
- restyled modals - fixed type errors - dashboard UI fixes
isTeacher and isStudent roles determine access to the dashboard and lobby respectively * fix some type errors and remove comments
as a workaround for the game server not being available in tests
group.clients and state.clients are separate objects in the lobby, so setting accepted on state.clients did not satisfy the condition of group.allClientsAccepted so the timeout would always expire
to be used for building a better game 'report' for completed games Co-authored-by: Sabrina Nelson <[email protected]> Co-authored-by: Kelly Tran <[email protected]>
- set `SHARED_APP_MODE=educator` in `.env` - set `DEPLOY_ENVIRONMENT=learn` in `config.mk`
alee
force-pushed
the
educator-version
branch
from
October 16, 2024 23:13
44ed728
to
a35dba8
Compare
currently deployed to https://learn.portofmars.asu.edu we should set up staging for this at some point as well |
Thanks. With the feature flag config remaining separate from deploy mode, just rotating on staging.portofmars.asu.edu should work fine for now |
alee
force-pushed
the
educator-version
branch
from
October 23, 2024 05:59
8e7001a
to
9048d1a
Compare
Co-authored-by: saachibm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide educator version of Port of Mars for MS/HS students and teachers
dashboard for classroom and student account management
Current plans are to deploy at https://learn.portofmars.asu.edu
TODO: